fix(database)!: remove cloudwatchLogsExportConfiguration #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
wotolom
pushed a commit
to wotolom/provider-aws
that referenced
this pull request
Aug 18, 2023
…ib#1835 Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
2 tasks
dee0
pushed a commit
to dee0sap/provider-aws
that referenced
this pull request
Aug 28, 2023
…ib#1835 Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
threadproc
pushed a commit
to swisscom/provider-aws
that referenced
this pull request
Sep 1, 2023
…ib#1835 Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
teeverr
pushed a commit
to swisscom/provider-aws
that referenced
this pull request
Oct 13, 2023
…ib#1835 Signed-off-by: Charel Baum (external expert on behalf of DB Netz AG) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
subject
database.RDSInstance:cloudwatchLogsExportConfiguration(CloudwatchLogsExportConfigurationis a specific parameter for theModifyDBInstancecall, that overlapped withEnableCloudwatchLogsExports, which is used inCreateDBInstance)atProvider.enabledCloudwatchLogsExportsisUpToDateandUpdate/GenerateModifyDBInstanceInput(as also used inDocDB.DBClustercontroller for the same parameters)EnableCloudwatchLogsExportslateinit (to allow user to disable all again with empty string; is AWS default)(Fixes #1795 regarding my comment there)
Breaking change ToDos/notes for users:
cloudwatchLogsExportConfigurationneed to instead useenableCloudwatchLogsExportsI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually